Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Doctrine ODM and Persistence dependencies #824

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Update Doctrine ODM and Persistence dependencies #824

merged 1 commit into from
Dec 21, 2023

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Dec 21, 2023

We dropped support for doctrine/cache in #804. Applications can upgrade to doctrine/persistence: 3.

Updating minimum dependencies helps maintenance by avoiding edge version incompatibility with future releases.

@GromNaN GromNaN requested review from alcaeus and franmomu December 21, 2023 10:59
malarzm
malarzm requested changes Dec 21, 2023
View reviewed changes
Copy link
Member

@malarzm malarzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please evaluate how is ORM and broader ecosystem doing before raising version

@GromNaN
Copy link
Member Author

GromNaN commented Dec 21, 2023 •
edited
Loading

There is already a huge switch to doctrine/persistence 3.
image

This package could be updated: https://github.com/phpstan/phpstan-doctrine/blob/310ab0f1ae9224c3c6aae39fa1e326a4053766c7/composer.json#L28C46-L28C46

Symfony is tested with persistence 3 only.

malarzm
malarzm approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@malarzm malarzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convinced 👼 let's do the same in ODM then

@GromNaN GromNaN merged commit 3785d8d into doctrine:5.0.x Dec 21, 2023
13 checks passed
@GromNaN GromNaN deleted the doctrine-deps branch December 21, 2023 12:44
@malarzm malarzm mentioned this pull request Dec 21, 2023
Merged
@franmomu franmomu mentioned this pull request Dec 22, 2023
Merged
@GromNaN GromNaN added the Task label Dec 22, 2023
@GromNaN GromNaN added this to the 5.0.0 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malarzm malarzm malarzm approved these changes

@alcaeus alcaeus alcaeus approved these changes

@franmomu franmomu Awaiting requested review from franmomu

Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@GromNaN @alcaeus @malarzm