-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add marker interface for event subscriber autoconfiguration #623
Add marker interface for event subscriber autoconfiguration #623
Conversation
Not sure if line should be adapted too https://github.com/doctrine/DoctrineMongoDBBundle/pull/623/files#diff-21bb4bdcf714a43b98948d9c96f74a1fR96 |
@alterphp thanks for the PR and sorry for the long wait!
What line are you referring to? Also would you mind adding a note to https://github.com/doctrine/DoctrineMongoDBBundle/blob/master/Resources/doc/events.rst? You may take a page from https://symfony.com/doc/master/bundles/DoctrineMongoDBBundle/first_steps.html#service-repositories |
@alterphp I'm afraid a conflict popped up, can you please rebase your changes atop current |
Yes, i'm not done, i had to switch to m'y dad duties
Le dim. 22 mars 2020 à 13:52, Maciej Malarz <[email protected]> a
écrit :
… @alterphp <https://github.com/alterphp> I'm afraid a conflict popped up,
can you please rebase your changes atop current master? Also once you'll
be rebasing, please squash your commits into 1.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#623 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFULTPW2MALO42FBETUAO3RIYCYHANCNFSM4K7P2MLQ>
.
|
19c4433
to
75631e6
Compare
@malarzm I do not remember what I was thinking... Sorry. I htink it's ok now ! |
75631e6
to
a2a8c5e
Compare
a2a8c5e
to
f746217
Compare
Thanks a lot @alterphp!
Sorry then, got a notification about a commit and acted on it :) |
No worries, you could not guess ! |
Totally copied from doctrine/DoctrineBundle#1119 !
This is first step in order to split Doctriner EventSubscriber autoconfiguration and then resolve conflicts introduced in https://github.com/KnpLabs/DoctrineBehaviors/blob/master/src/Bundle/DependencyInjection/DoctrineBehaviorsExtension.php#L29