Add support to set PostgreSQL application_name #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is dependant upon doctrine/dbal#798 . PostgreSQL allows the user to set the application_name is connecting to database. It is useful for monitoring purposes. Currently one could just manually add 'application_name=foo' to DSN by appending it to dbname, like: dbname: %database_name% application_name=foo It works but having a parameter eases setting it.
| @@ -47,6 +47,7 @@ | |||
| <xsd:attribute name="port" type="xsd:string" /> | |||
| <xsd:attribute name="user" type="xsd:string" /> | |||
| <xsd:attribute name="password" type="xsd:string" /> | |||
| <xsd:attribute name="application_name" type="xsd:string" /> | |||
There was a problem hiding this comment.
Should probably be application-name to be consistent with the other options.
There was a problem hiding this comment.
I thought about that, but the GUC variable and the DSN part is called application_name. Wouldn't it make more sense for the users?
There was a problem hiding this comment.
the XML format always uses dashes in places where YAML uses underscores (it is normalized by the config system). What makes sense for users is to respect the XML convention (they will get autocompletion based on the XSD in their IDE anyway)
|
Well, it cannot be merged here until the DBAL team merges the feature in DBAL itself |
kimhemsoe
added a commit
that referenced
this pull request
Jan 10, 2016
Add support to set PostgreSQL application_name
|
Thanks @davividal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependant upon doctrine/dbal#798 .
PostgreSQL allows the user to set the application_name is connecting
to database. It is useful for monitoring purposes.
Currently one could just manually add 'application_name=foo' to DSN
by appending it to dbname, like:
It works but having a parameter eases setting it.