Fix the JS code in the profiler panel for Symfony 7 #1748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Psalm errors are probably caused by the release of DBAL 4 and/or ORM 3.0, where the CI job running the static analysis uses the new major versions. |
ostrolucky
reviewed
Feb 5, 2024
ostrolucky
approved these changes
Feb 5, 2024
dmaicher
approved these changes
Feb 5, 2024
Seb33300
reviewed
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Symfony 7, the
Sfjsobject holding the code for the web debug toolbar is not present in the profiler pages anymore as the JS code has been split.This replaces its usages by native browser APIs instead (even when running on older versions of Symfony).