Fix #1230 - Console commands do not respect driverOptions when master/slave configuration is used

[ostrolucky]

@stof could you please check this, you were the one adding driverOptions to this blacklist, so there is a tiny chance you would know if that was on purpose

[greg0ire]

Should the file on line 114 be modified to add options in both the master and the slave, to make things more interesting? Without your change, what happens? Are the master's options copied to the slave?

[ostrolucky]

There is actually no such option as "master" configuration key/option. What's defined one level above slaves is what's master. And yes that's how this patch works. It copies everything from master to slaves except the things in the list.

[greg0ire]

Indeed, I read the issue backwards. What if there is already an option at the slave level? Will it be overwritten? Should the configuration at

DoctrineBundle/Tests/DependencyInjection/Fixtures/config/yml/dbal_service_single_master_slave_connection.yml

Lines 2 to 15 in 6f3f4d9

	dbal:
	dbname: mysql_db
	user: mysql_user
	password: mysql_s3cr3t
	unix_socket: /path/to/mysqld.sock
	keep_slave: true
	default_table_options:
	engine: InnoDB
	slaves:
	slave1:
	user: slave_user
	dbname: slave_db
	password: slave_s3cr3t
	unix_socket: /path/to/mysqld_slave.sock

be modified to test what happens when there are options in both levels? I'd expect some kind of merge to happen, but I'm not sure which level should get the priority. Maybe the slave one, because otherwise, there would be a BC-break?

[ostrolucky]

I don't think that's necessary. I didn't change merging logic. Whatever slave specifies is kept for that slave.