Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow DBAL 3.0 and ignore ORM tests on php 8 #1173

Merged
merged 1 commit into from
May 26, 2020
Merged

Allow DBAL 3.0 and ignore ORM tests on php 8 #1173

merged 1 commit into from
May 26, 2020

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented May 25, 2020 •
edited
Loading

On order to run at least a few tests on php 8, this PR…

  • Allows DBAL 3.0 to be installed because DBAL 2 will trigger fatal errors on php 8.
  • Uninstalls ORM on the php 8 build because there currently is no ORM version that allows DBAL 3.
  • Skips all tests that require ORM if it's not there.
  • Ignores deprecation warnings because PHPUnit will trigger lots of them. We need to upgrade PHPUnit to fix this.

@derrabus derrabus force-pushed the improvement/skip-orm-on-php8 branch 3 times, most recently from e76baff to 3dd1969 Compare May 25, 2020 22:51
@derrabus derrabus marked this pull request as ready for review May 25, 2020 22:55
alcaeus
alcaeus reviewed May 26, 2020
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny suggestion regarding the duplicate composer update, but LGTM other than that.

.travis.yml Outdated Show resolved Hide resolved
@derrabus derrabus force-pushed the improvement/skip-orm-on-php8 branch from 3dd1969 to e57eada Compare May 26, 2020 11:21
@alcaeus alcaeus added the CI label May 26, 2020
@alcaeus alcaeus added this to the 1.12.11 milestone May 26, 2020
@alcaeus alcaeus merged commit f5a5a3d into doctrine:1.12.x May 26, 2020
@derrabus derrabus deleted the improvement/skip-orm-on-php8 branch May 26, 2020 11:31
@derrabus derrabus mentioned this pull request May 26, 2020
Merged
@github-actions github-actions bot mentioned this pull request Nov 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
1.12.11
Development

Successfully merging this pull request may close these issues.
2 participants
@derrabus @alcaeus