Update Entity Listener Docs to New Service Style #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching to Symfony 4's new container style: classes for service names.
|
This style is recommended only for applications. For bundles, decoupling the class and the id is still recommended. |
|
Aaaand, this is for the doc, so my comment is void... sorry :D |
|
@nicolas-grekas Is this recommendation somewhere in the Symfony docs? Maybe this could be added as a link since the docs just explain how to use the bundle. |
ostrolucky
reviewed
May 4, 2020
Renaming `UserListener` to `App\UserListener` so it is clear to unaware users that it is FCQN Addressing [note](doctrine#1161 (review)) from @ostrolucky.
ostrolucky
approved these changes
May 14, 2020
SenseException
approved these changes
May 18, 2020
There was a problem hiding this comment.
This style is recommended only for applications. For bundles, decoupling the class and the id is still recommended.
A link referencing to this information can be added sometime later. For now, this is 👍 . Or do we need to target a different branch and do an upmerge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to Symfony 4's new container style: classes for service names.