Update namespace of the metadata driver #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ostrolucky
approved these changes
Feb 26, 2020
maxhelias
approved these changes
Feb 26, 2020
SenseException
requested changes
Feb 27, 2020
There was a problem hiding this comment.
@ostrolucky This isn't the only occurence of Doctrine\Common\Persistence for this branch. Should this PR cover all namespaces or is having a small change like in this PR okay?
|
Other occurrences are services which do have appropriate persistence aliases and need to stay for BC. This looks to be the only occurrence we can change safely. |
SenseException
approved these changes
Mar 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.