Improve replaceQueryParameters function for empty array #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we shouldn't fix such superficial issue, but fix underlying problem - For some reason, bundle is not using |
This copies DBAL behaviour
ostrolucky
approved these changes
Mar 14, 2020
There was a problem hiding this comment.
I've investigated possibility to replace our mechanism with SqlParserUtils::expandListParameters. Unfortunately behaviour of this DBAL function is different than we need for named parameters without array_ types 1, 2. So this is good to go. Just made very minor improvement since I had branch already checked out.
greg0ire
approved these changes
Mar 14, 2020
|
Thanks @VincentLanglet ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1143