-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add priority support for tagged entity listeners #1135
Conversation
*/ | ||
public function testAbstractLazyEntityListener() : void | ||
public function testAbstractEntityListener() : void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a BC break, merely misleading test case. It DID throw even for non-lazy abstract listeners before.
@@ -62,10 +66,6 @@ public function process(ContainerBuilder $container) | |||
if (! isset($attributes['lazy']) && $resolverSupportsLazyListeners || $lazyByAttribute) { | |||
$listener = $container->findDefinition($id); | |||
|
|||
if ($listener->isAbstract()) { | |||
throw new InvalidArgumentException(sprintf('The service "%s" must not be abstract as this entity listener is lazy-loaded.', $id)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check is done from within findAndSortTaggedServices
now, so no need for it here anymore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks @ostrolucky! |
Fixes #991