-
-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Updating the Doctrine commands for the new style guide #466
Comments
There is 2 things to take care about:
|
btw, this is not required to be done before the Symfony feature freeze though: Doctrine feature freeze does not happen at the same time. |
As @stof mentioned there aren't many commands to update in doctrine bundle itself, but of course this contribution would be welcome. @javiereguiluz are you still interested in this? Sorry for not getting to you not sooner! |
I think @OskarStark took care of the ORM part: doctrine/orm#6655 |
Better late than never: no logic here to take care of. Closing. |
I wouldn't say no logic, we have eg. |
We want to update all Symfony commands to use the new style guide and we want to do that before the "feature freeze" period starts in two days.
My question is: if I create some pull requests udpdating the Doctrine commands, will they be accepted?(assuming they are technically correct of course)
The text was updated successfully, but these errors were encountered: