Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Updating the Doctrine commands for the new style guide #466

Closed
javiereguiluz opened this issue Sep 28, 2015 · 6 comments
Closed

[RFC] Updating the Doctrine commands for the new style guide #466

javiereguiluz opened this issue Sep 28, 2015 · 6 comments

Comments

@javiereguiluz
Copy link
Contributor

We want to update all Symfony commands to use the new style guide and we want to do that before the "feature freeze" period starts in two days.

My question is: if I create some pull requests udpdating the Doctrine commands, will they be accepted?(assuming they are technically correct of course)

@stof
Copy link
Member

stof commented Sep 28, 2015

There is 2 things to take care about:

  • most commands are in the ORM itself, not in the bundle. So this will depend on the ORM team, not on me
  • I don't want to drop support for Symfony 2.3 until it reaches the end of support. otherwise I would have to maintain 2 versions of the bundle (as shipping an unmaintained bundle in the SE is not an option) and I would like to avoid that.

@stof
Copy link
Member

stof commented Sep 28, 2015

btw, this is not required to be done before the Symfony feature freeze though: Doctrine feature freeze does not happen at the same time.

@ostrolucky
Copy link
Member

As @stof mentioned there aren't many commands to update in doctrine bundle itself, but of course this contribution would be welcome.

@javiereguiluz are you still interested in this? Sorry for not getting to you not sooner!

@greg0ire
Copy link
Member

greg0ire commented Dec 1, 2019

I think @OskarStark took care of the ORM part: doctrine/orm#6655

@alcaeus
Copy link
Member

alcaeus commented Dec 2, 2019

Better late than never: no logic here to take care of. Closing.

@alcaeus alcaeus closed this as completed Dec 2, 2019
@ostrolucky
Copy link
Member

I wouldn't say no logic, we have eg. doctrine:database:create, doctrine:database:drop etc so if anybody wants to update it, feel free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants