Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ManagerRegistery should reset entity managers on kernel.reset #1083

Closed
nicolas-grekas opened this issue Dec 2, 2019 · 2 comments
Closed

ManagerRegistery should reset entity managers on kernel.reset #1083

nicolas-grekas opened this issue Dec 2, 2019 · 2 comments
Assignees
@alcaeus
Labels
Bug
Milestone
1.12.3

Comments

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Dec 2, 2019 •
edited
Loading

Follow up of symfony/symfony#34720

ManagerRegistry is able to reset entity managers, but I think we missed wiring this capability with the kernel.reset tag so that EM are reset between requests in long-running loops.

Given the dependency on LazyLoadingInterface, this should be done only when the interface is found of course.
@nicolas-grekas nicolas-grekas mentioned this issue Dec 2, 2019
Closed
@alcaeus alcaeus added the Bug label Dec 2, 2019
@alcaeus alcaeus added this to the 1.12.3 milestone Dec 2, 2019
@alcaeus alcaeus self-assigned this Dec 2, 2019
@alcaeus
Copy link
Member

alcaeus commented Dec 2, 2019 •
edited
Loading

I can take a look later today. Treating as a bug for now so we can also fix this in 1.12, otherwise we'd have this in 2.1 only.

@alcaeus alcaeus mentioned this issue Dec 17, 2019
Merged
@alcaeus
Copy link
Member

alcaeus commented Dec 18, 2019

Fixed in #1099, will be released in 1.12.3.

@alcaeus alcaeus closed this as completed Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alcaeus alcaeus

Labels
Bug
Projects
None yet
Milestone
1.12.3
Development

No branches or pull requests
3 participants
@nicolas-grekas @alcaeus @ostrolucky