Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rely on autoincremental ids in materialized path tests #2684

Merged
merged 1 commit into from
Sep 3, 2023

Conversation

franmomu
Copy link
Collaborator

@franmomu franmomu commented Aug 29, 2023

First of all, I'm not sure if this is the right change, I'm not familiarized with materialized path, I've seen is that it stores the ids in the path, since we cannot rely on the autoincremental ids, this PR finds the root node of a particular node and compares that their treeNodeValue are the same.

This tries to fix the remaining failing test when using doctrine/orm 2.16.2

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.32% 🎉

Comparison is base (98ebb3f) 79.23% compared to head (915f482) 79.55%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2684      +/-   ##
==========================================
+ Coverage   79.23%   79.55%   +0.32%     
==========================================
  Files         161      161              
  Lines        8412     8412              
==========================================
+ Hits         6665     6692      +27     
+ Misses       1747     1720      -27     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@franmomu franmomu force-pushed the fix_test_materialized branch from d327807 to 82164ac Compare August 29, 2023 10:09
@franmomu franmomu requested a review from phansys August 29, 2023 13:38
@franmomu franmomu force-pushed the fix_test_materialized branch from 82164ac to 915f482 Compare September 3, 2023 19:58
@phansys phansys merged commit 5502bae into doctrine-extensions:main Sep 3, 2023
21 checks passed
@phansys
Copy link
Collaborator

phansys commented Sep 3, 2023

Thanks @franmomu!

@franmomu franmomu deleted the fix_test_materialized branch September 3, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants