Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugin "words countable" #1105

Closed
wants to merge 1 commit into from
Closed

Conversation

827652549
Copy link

@827652549 827652549 commented Apr 7, 2020

This is a plugin to add word count for markdown files of docsify.

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:


  • DO NOT include files inside lib directory.

This is a plugin to add word count for markdown files of docsify.
@anikethsaha
Copy link
Member

Can you please add the link to awesome-docsify repo instead of here cause here we dont add many as it goes a long list

@Koooooo-7
Copy link
Member

BTW:
code format countable.js and good code annotation in English for the sort of unification ours. 👍

@827652549
Copy link
Author

I have formatted the code and replaced it with English annotation.thanks @Koooooo-7

@anikethsaha
Copy link
Member

As I mentioned earlier , it has to be in awesome-docsify repo.
Closing this for now.
Please comment if anything needs to be changed in this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants