Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML (image) stopped working in name property on Github pages #990

Closed
Hainesy opened this issue Dec 28, 2019 · 1 comment · Fixed by #991
Closed

HTML (image) stopped working in name property on Github pages #990

Hainesy opened this issue Dec 28, 2019 · 1 comment · Fixed by #991

Comments

@Hainesy
Copy link

Hainesy commented Dec 28, 2019

We had a logo top left using HTML embedded in the name field but it's suddenly stopped working in Github pages.

window.$docsify = {
    name: `\
    <svg width="136" height="28" xmlns="http://www.w3.org/2000/svg">\
      <g fill="#D90268">\
         <path d="..."/>\
      </g>\
    </svg><br>\
    Our custom header`
}
@anikethsaha
Copy link
Member

Actually we recently did escaping of tags and other char in the latest version. But I am thinking of reverting that.
Till the next release use v4.9.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants