Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown header broken since v4.8.3 #717

Closed
Kikobeats opened this issue Dec 11, 2018 · 4 comments
Closed

Markdown header broken since v4.8.3 #717

Kikobeats opened this issue Dec 11, 2018 · 4 comments

Comments

@Kikobeats
Copy link
Contributor

If I block the version to v4.8.2, the Get Started is correctly rendered

screenshot 2018-12-11 at 12 42 31

But using any version since that (v4.8.3 to latest), the first header is not rendered:

screenshot 2018-12-11 at 12 44 15

@dabrave
Copy link

dabrave commented Dec 21, 2018

same issue here. Thanks Kikobeats for pointing it out!

@timaschew
Copy link
Member

timaschew commented Jan 27, 2019

I found it it's related to the upgrade of the markdown parser, which happened unfortunately between 4.8.2 and 4.8.3 even if it's not documented nor seen by any package.json or package-lock.json (but this is another topic).

It seems that a regex has changed which influence headers if they're used after html code.

@Kikobeats you're using a docsify plugin which prepends some HTML code for the edit button.
Due to a security reason you need to use two blanklinkes (\n) as delimiter when you're mixing HTML and markdown.

@timaschew timaschew mentioned this issue Jan 28, 2019
5 tasks
@timaschew
Copy link
Member

Closing due to wrong usage of mixed content: HTML + markdown

@Kikobeats
Copy link
Contributor Author

It works! Thanks for addressing that 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants