Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Sidebar is not loaded and is hidden, page-to-page navigation will shortly stop due to error #1907

Closed
1 task done
paulhibbitts opened this issue Oct 22, 2022 · 1 comment · Fixed by #1909
Closed
1 task done
Labels
bug confirmed as a bug

Comments

@paulhibbitts
Copy link
Collaborator

Bug Report

Steps to reproduce

  1. Create two pages with links to each other
  2. Set loadSidebar: false and hideSidebar: true
  3. View Docsify site, and navigate between 2 pages several times

What is current behaviour

Viewing the console will reveal an error (TypeError: null is not an object (evaluating 'e.parentNode')), and navigating between pages will stop working.

What is the expected behaviour

No console error, and navigating between pages will continue working.

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS:

  • Node.js version:

  • npm/yarn version:

  • Browser version:

  • Docsify version:

  • Docsify plugins:

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)

@Koooooo-7 Koooooo-7 added the bug confirmed as a bug label Oct 25, 2022
@paulhibbitts
Copy link
Collaborator Author

Thank you very much @Koooooo-7 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed as a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants