Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flaky tests #1602

Closed
trusktr opened this issue Jun 25, 2021 · 2 comments · Fixed by #1736
Closed

flaky tests #1602

trusktr opened this issue Jun 25, 2021 · 2 comments · Fixed by #1736

Comments

@trusktr
Copy link
Member

trusktr commented Jun 25, 2021

The tests seem to be flaky for some reason. I re-ran the tests in #1598 like 5+ times, and could not get them to pass. Each time, a different test failed.

cc @jhildenbiddle Any ideas?

@jhildenbiddle
Copy link
Member

@trusktr --

I'm seeing the same behavior when testing locally. The first time I ran all tests everything passed without issue. The second time a failure occurred in test/e2e/index-file.test.js. I can confirm, however, that skipping the tests in index-file.test.js resulted in five test runs without a single failure. I haven't spent a ton of time on this, but Playwright is providing useful information to help track down the issue:

CleanShot 2021-06-26 at 17 39 14@2x

It's clear from the text in the error that when this test fails, the content being loaded into #main is from plugins.md and not README.md as expected. Why? Not sure yet, but this gives us a place to start.

More to come...

@jhildenbiddle jhildenbiddle linked a pull request Jan 30, 2022 that will close this issue
9 tasks
@jhildenbiddle
Copy link
Member

Addressed in #1736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants