Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed quotes bug #1597

Closed
1 task done
luwol03 opened this issue Jun 21, 2021 · 1 comment · Fixed by #1598
Closed
1 task done

embed quotes bug #1597

luwol03 opened this issue Jun 21, 2021 · 1 comment · Fixed by #1598
Labels
bug confirmed as a bug

Comments

@luwol03
Copy link
Contributor

luwol03 commented Jun 21, 2021

Bug Report

Steps to reproduce

  1. Create empty docsify project
  2. Add following to one markdown file
[gist: script.js](https://gist.githubusercontent.com/anikethsaha/f88893bb563bb7229d6e575db53a8c15/raw/script.js ":include :type=code")
  1. See not renderd embed

What is current behaviour

Embedded gist will not be renderd.

What is the expected behaviour

Embedded gist should be renderd.

Other relevant information

This is not working because the type of quotes are not supported. The default prettier configuration changes the '' to "". And if you have auto format toggled on, you're not be able to save the file working.

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: any os

  • Node.js version: any nodejs version

  • npm/yarn version: any yarn/npm version

  • Browser version: any browser and version

  • Docsify version: 4.12.1

  • Docsify plugins: none

Please create a reproducible sandbox

Edit docsify-template-forked-zlwql

Mention the docsify version in which this bug was not present (if any)

@trusktr trusktr added the bug confirmed as a bug label Jun 21, 2021
@trusktr
Copy link
Member

trusktr commented Jun 21, 2021

As per conversation at https://discord.com/channels/713647066802421792/719155521109884978/855738415399043082, double quotes don't work while single quotes do, but I haven't tried this particular feature to confirm.

I imagine there's an easy fix for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed as a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants