Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cannot read property 'startsWith' of undefined #1358

Merged
merged 5 commits into from
Aug 28, 2020

Conversation

sy-records
Copy link
Member

@sy-records sy-records commented Aug 26, 2020

Summary

I fixed #1356 and found another error.

image

    const path = paths[0];

    if (Array.isArray(config.pathNamespaces)) {
      namespaceSuffix =
        config.pathNamespaces.find(prefix => path.startsWith(prefix)) ||
        namespaceSuffix;
    } 

path is undefined when only a readme file is present.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

@vercel
Copy link

vercel bot commented Aug 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/qdh8l2jcs
✅ Preview: https://docsify-preview-git-fork-sy-records-fix-typo.docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 26, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6c6cad3:

Sandbox Source
docsify-template Configuration

@sy-records sy-records requested review from anikethsaha and a team August 26, 2020 00:58
@sy-records
Copy link
Member Author

@palkan Can you review it?

anikethsaha
anikethsaha previously approved these changes Aug 26, 2020
src/plugins/search/search.js Outdated Show resolved Hide resolved
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @palkan said make sense.

Copy link
Contributor

@palkan palkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sy-records sy-records merged commit 9351729 into docsifyjs:develop Aug 28, 2020
@sy-records sy-records deleted the fix-typo branch August 28, 2020 01:05
@sy-records sy-records mentioned this pull request Feb 5, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants