-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emoji :+1:
not rendering
#1162
Comments
use |
@anikethsaha Got it. But |
In emoji plugin we are hitting Github's service for emoji rendering, I do think that need to take a look. may be we should change |
|
yup, we can change them to |
can i work on this? |
sure , go ahead 👍 |
Hello @anikethsaha I'm new to the codebase, can you guide me? |
sure. let me know if you have any question. |
Bug Report
When using
:+1:
in markdown the corresponding thumbs up is not rendering.Steps to reproduce
Add
:+1:
in markdown anddocsify serve docs
What is current behaviour
The string
:+1:
is displayed as is in the rendered page.What is the expected behaviour
The emoji for thumbs up( 👍 ) should be shown.
Other relevant information
Bug does still occur when all/other plugins are disabled?
Your OS: MacOS Catalina
Node.js version: v13.3.0
npm/yarn version: v6.14.4
Browser version: Chrome v81.0.xxx
Docsify version: latest at
cdn.jsdelivr.net/npm/docsify/lib/docsify.min.js
Docsify plugins: emoji
Please create a reproducible sandbox
![Sandbox](https://codesandbox.io/s/snowy-cookies-f7ipv?file=/index.html
Mention the docsify version in which this bug was not present (if any)
NA
The text was updated successfully, but these errors were encountered: