Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji :+1: not rendering #1162

Closed
1 task done
ppipada opened this issue May 10, 2020 · 9 comments · Fixed by #1187
Closed
1 task done

Emoji :+1: not rendering #1162

ppipada opened this issue May 10, 2020 · 9 comments · Fixed by #1187
Assignees

Comments

@ppipada
Copy link

ppipada commented May 10, 2020

Bug Report

When using :+1: in markdown the corresponding thumbs up is not rendering.

Steps to reproduce

Add :+1: in markdown and docsify serve docs

What is current behaviour

The string :+1: is displayed as is in the rendered page.

What is the expected behaviour

The emoji for thumbs up( 👍 ) should be shown.

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: MacOS Catalina

  • Node.js version: v13.3.0

  • npm/yarn version: v6.14.4

  • Browser version: Chrome v81.0.xxx

  • Docsify version: latest at cdn.jsdelivr.net/npm/docsify/lib/docsify.min.js

  • Docsify plugins: emoji

Please create a reproducible sandbox

![Sandbox](https://codesandbox.io/s/snowy-cookies-f7ipv?file=/index.html

Mention the docsify version in which this bug was not present (if any)

NA

@anikethsaha
Copy link
Member

use :thumbsup: instead .

@ppipada
Copy link
Author

ppipada commented May 10, 2020

@anikethsaha Got it. But :+1: is a standard shortcode used for thumbs up. Github markdown does support it. Any specific reason this is not supported?

@anikethsaha
Copy link
Member

In emoji plugin we are hitting Github's service for emoji rendering, I do think that + is getting encoded to %2B and not able to get resolved.

need to take a look.

may be we should change +1 to thumbsup in the plugin and same for -1 🤔

@ppipada
Copy link
Author

ppipada commented May 10, 2020

:-1: also has the same issue. Added this to sandbox.

@anikethsaha
Copy link
Member

yup, we can change them to thumbsup and thumbsdown in the plugin.

@radiohertz
Copy link

can i work on this?

@anikethsaha
Copy link
Member

sure , go ahead 👍

@radiohertz
Copy link

Hello @anikethsaha I'm new to the codebase, can you guide me?

@anikethsaha
Copy link
Member

sure. let me know if you have any question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants