default html img resize if no height included

[maubuz]

Summary

When image is resized by providing only a width, it does not set the height. Let html resize automatically to respect the aspect ratio.

Fixes #1064 .

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Code style update
• Refactor
• Docs
• Build-related changes
• Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

• Yes
• No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

• When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

• Chrome
• Firefox
• Safari
• Edge
• IE

If adding a new feature, the PR's description includes:

• A convincing reason for adding this feature
• Related documents have been updated
• Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

---

• DO NOT include files inside lib directory.

[maubuz]

Unit test suite (build 12.x) is failing in render.test.js, line 171 because test expects the output to include a height when only a width is provided.

Should the test be adjusted?

[anikethsaha]

Unit test suite (build 12.x) is failing in render.test.js, line 171 because test expects the output to include a height when only a width is provided.

Should the test be adjusted?

yes

[anikethsaha]

💯

[anikethsaha]

I am not sure whether I can release this soon. Maybe this weekend!
so I would advice is you want this to be changed, you can try

![](<link here> ':width=100')

[maubuz]

Thank you! I don't mind waiting. For now, I'll just point my index.html to my compiled version of docsify.min.js.
Happy to contribute to such a great project!

Also, I can't seem to get the syntax ':width=100' to work. Is it currently supported?

[anikethsaha]

Also, I can't seem to get the syntax ':width=100' to work. Is it currently supported?

oops...I we dont have support for that. I thought we had support for building dynamic attributes from these markdown syntax.

I guess we can have that, that would solve many similar issues

[arelstone]

I think this looks legit to me. Didn't think of this when i did the refactoring

[jihao]

Please, can someone merge this pull request?
I had to change to older version which works fine.

<script src="//unpkg.com/[email protected]/lib/docsify.js"></script>

[maubuz]

Let me know if there is anything required from my end to complete the merge.
A test is failing with a timeout error but I don't see the connection with this PR.

[maubuz]

I did a rebase on top of latest develop branch. Nothing was changed in the code.
All tests are passing now.

[anikethsaha]

thanks