Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Automate build and releases #82

Closed
raulfdm opened this issue Dec 22, 2019 · 5 comments · Fixed by #83
Closed

[Proposal] Automate build and releases #82

raulfdm opened this issue Dec 22, 2019 · 5 comments · Fixed by #83

Comments

@raulfdm
Copy link
Contributor

raulfdm commented Dec 22, 2019

Hello guys.

After the problem reported here (#78), I took a look on the project and I notice the bin it's the code you maintain.

Maybe a final solution for this would be automate this process by using a tool like rollup with a very basic setup.

What do you think about it?

I have experience with this kind of infrastructure, if you want I can open a PR with a proposal.

@anikethsaha
Copy link
Member

Great!!
If you are confident with rollup, then go for it else I am experienced with webpack so I would lean more towards webpack. But anyway I guess it won't be much of a difference.
Also, don't put everything in one PR, you can do with each step-wise, like first just the setup and then
changes in the advance level etc....
I guess you can wait until the tests are set up properly it will be easy to pick the breakup if any

@jamesgeorge007 what do you think?

@raulfdm
Copy link
Contributor Author

raulfdm commented Dec 22, 2019

Usually I use webpack when I'm working with React, storybook or something which I need to combine HTML + JS.

For pure JS libs I'm seeing a lot of people using rollup because it's WAY simpler. But indeed, It's pretty much the same.

@raulfdm
Copy link
Contributor Author

raulfdm commented Dec 22, 2019

automate-build

@raulfdm
Copy link
Contributor Author

raulfdm commented Dec 22, 2019

My question is only about how the deployment process will be.

Maybe I can I also came up with an auto-release process via semantic-release since you guys are already using conventional commit messages.

@anikethsaha
Copy link
Member

Maybe I can I also came up with an auto-release process via semantic-release since you guys are already using conventional commit messages.

yup we are using semantic-release. I guess you added that already in the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants