-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the very useful head plugin #4
Comments
+1 |
You could use shared directory as shown in README.md:
For somebody that is already using persistent storage this would also be the best way to do it. |
I disagree, I like it the way it is. I think the base image (that's semi-official) should not come with anything that isn't core to elasticsearch. It is so easy to extend, either by configuring as the comment above, or writing a Dockerfile that builds
|
@ramseykhalaf I'm currently setting the plugins directory to the default location, so that it is baked into the docker image. Now, I may get hosed if I use a plugin that tries to store local state to plugins location, but am currently using kibana and marvel which persist state to elasticsearch and am probably OK there. Since I am commenting, don't feel strongly, but a baked in way to specify optional plugins would be nice. |
@ppearcy What change would you suggest? |
Maybe this:
Customizing Docker images is certainly easy, so maybe this is an overkill. |
I'm -1 for adding plugins by default. Still. I'd prefer that this Dockerfile install elasticsearch as a service so it will be easy to restart elasticsearch when needed. For example, when adding Marvel to my own Dockerfile, it does not work as I am expecting as dockerfile/elasticsearch launched My Dockerfile:
I would suggest to:
Wanna a PR for this? |
+1 for using deb images |
Having plugins in the
Hence my suggestion is to to remove p.s. +1 for using deb images @dadoonet |
@neil-rubens +1 for removing plugins from the /data directory. Conceptually, this makes much more sense. There is definitely confusion on how to properly install a plugin using containers, I believe this is the fundamental reason the question came up in the first place. If it was trivial, which it is obviously not, I don't think there'd be so much discussion/debate. At the very least, This Dockerfile could use better documentation on A) how to install a plugin using the /data/plugins method and B) how to bake one permanently with a Dockerfile. |
@dadoonet I think this way is how docker should be used. I think ideally you should have one service per container. Docker has a --restart flag that can be used to make sure the process is kept running. You shouldn't have two daemon services running in the same container. If for example you have your app server and elasticsearch, they would be in separated (but probably linked) containers. This way you can scale the two components independently. I've just started with Docker so take my words as my current vision of Docker :) |
+1 for @neil-rubens, it doesn't make sense to have plugins at /data/plugins. A workaround for the time being is to have the following dockerfile:
where config/elasticsearch.yml is :
|
Also hit this issue, and agree that moving the plugins out of the Until then, the workaround's posted above should work for us |
👍 |
An easy way to install a plugin into a running elasticsearch instance is:
|
Would be nice to add this plugin:
The text was updated successfully, but these errors were encountered: