validate duplicate published port in ServiceSpec

[allencloud]

fixed #1494

Currently, swarmkit checks the whole *port to avoid duplication.

This PR makes swarmkit to check the published port of PortConfig.

Signed-off-by: allencloud [email protected]

[codecov-io]

Current coverage is 55.34% (diff: 100%)

Merging #1495 into master will increase coverage by 0.05%

@@             master      #1495   diff @@
==========================================
  Files            82         82          
  Lines         12873      12873          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           7118       7125     +7   
+ Misses         4767       4765     -2   
+ Partials        988        983     -5   

Powered by Codecov. Last update 586bf3a...8dd4c69

[aaronlehmann]

ping @mrjana

[mrjana]

LGTM

[aaronlehmann]

LGTM

ping @cpuguy83 PTAL

[cpuguy83]

LGTM

[jamesdmorgan]

Hi, has anybody come across an issue when registering a service using udp & tcp on the same port?

"Error response from daemon: rpc error: code = 3 desc = EndpointSpec: duplicate published ports provided"

This has started happening with v1.12.2 and was fine with v1.12.1

I'm running the service with

-p 5555:5555/tcp
-p 5555:5555/udp
-p 5556:5556/tcp

[aaronlehmann]

@jamesdmorgan: Thank you for pointing this out. I opened #1632 to fix it.