This repository has been archived by the owner on Feb 1, 2021. It is now read-only.
use docker/docker/pkg/discovery and update godeps #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vieux
added
area/discovery
status/2-code-review
priority/P1
and removed
status/0-triage
labels
2 tasks
|
ping @dongluochen @abronan |
|
LGTM. |
vieux
changed the title
Signed-off-by: Mary Anthony <[email protected]>
Signed-off-by: Victor Vieux <[email protected]>
Signed-off-by: Victor Vieux <[email protected]>
Signed-off-by: Victor Vieux <[email protected]>
|
LGTM thanks @vieux! 😉 |
abronan
added a commit
that referenced
this pull request
Jan 13, 2016
use docker/docker/pkg/discovery and update godeps
ChristianKniep
pushed a commit
to ChristianKniep/swarm
that referenced
this pull request
Jul 27, 2017
use docker/docker/pkg/discovery and update godeps
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1594
I had to update godeps at the same time,
that's why the PR can look big, but you can just review the 1st commit.
Since it's going to go away soon, I left
tokenindocker/swarmit's better not to add something in engine to remove it one version later.