Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support being able to set CPU/memory limits from the CLI (Docker Desktop) #170

Closed
myitcv opened this issue Nov 16, 2020 · 7 comments
Closed
Labels
community_new New idea raised by a community contributor docker_desktop Improvements or additions to Docker Desktop

Comments

@myitcv
Copy link

myitcv commented Nov 16, 2020

Per @nebuk89 on Slack, raising this as a follow up to docker/for-mac#4907

Tell us about your request

I would like to be able to configure the CPU and memory limits from the CLI (context here is Docker Desktop for Mac)

Which service(s) is this request for?

Docker Desktop (for Mac)

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

When using Docker Desktop for Mac via a CI setup (i.e. headless) environment, it is impossible to set CPU/memory limits.

Are you currently working around the issue?

No, there does not appear to be a workaround as of today.

Additional context

n/a

@myitcv myitcv added the community_new New idea raised by a community contributor label Nov 16, 2020
@stephen-turner
Copy link

BTW there is a workaround to edit the settings.json file directly. (This doesn't take away from the feature request to be able to do it on the CLI).

@myitcv
Copy link
Author

myitcv commented Nov 18, 2020

Thanks @stephen-turner - is there a reference/example of this file somewhere I could use?

@stephen-turner
Copy link

No, it's not documented, but the format is pretty obvious.

@stephen-turner stephen-turner added the docker_desktop Improvements or additions to Docker Desktop label Nov 18, 2020
@myitcv
Copy link
Author

myitcv commented Nov 18, 2020

Thanks is there an example file I can look at somewhere?

@stephen-turner
Copy link

You have one on your machine already, so it's just a matter of editing the existing one. Sorry, I don't remember the exact path at the moment as I'm on a Windows machine, but I think you can find it: if not, ask again.

@myitcv
Copy link
Author

myitcv commented Nov 18, 2020

I don't actually have Docker installed myself, I'm iterating via GitHub Actions.

But I found the answer:

https://github.com/tmc/d4mctl/blob/91364c404614ebc87d036212bcc5c1974ace6a87/d4m/config.go#L11

Thanks again!

@stephen-turner
Copy link

Great, thanks.

Your request is actually a specific instance of a class of feature requests we get, so I've made a roadmap item for the general case, #172. I'll close this ticket in favour of that one, but please do vote on that one with a 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_new New idea raised by a community contributor docker_desktop Improvements or additions to Docker Desktop
Projects
None yet
Development

No branches or pull requests

2 participants