Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octokit dependency: should it be a dev dependency #22

Closed
karolz-ms opened this issue Jul 7, 2020 · 1 comment · Fixed by #23
Closed

Octokit dependency: should it be a dev dependency #22

karolz-ms opened this issue Jul 7, 2020 · 1 comment · Fixed by #23

Comments

@karolz-ms
Copy link

The SDK causes the consumer to reference a bunch of octokit (GitHub client) packages. That seems to be a development-only dependency? Should it be classified as such?
@rumpl
Copy link
Member

rumpl commented Jul 7, 2020

It’s completely a dev dependency. Will fix. Sorry about that

@karolz-ms karolz-ms mentioned this issue Jul 7, 2020
Merged
@rumpl rumpl mentioned this issue Jul 8, 2020
Merged
@rumpl rumpl closed this as completed in #23 Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused dependecies docker/node-sdk
2 participants
@rumpl @karolz-ms