Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label overwrite does not works as expected #289

Closed
sergey-safarov opened this issue Apr 21, 2023 · 3 comments
Closed

label overwrite does not works as expected #289

sergey-safarov opened this issue Apr 21, 2023 · 3 comments

Comments

@sergey-safarov
Copy link

sergey-safarov commented Apr 21, 2023

Behaviour

In the action description, you can read

If some OCI Image Format Specification labels generated are not suitable, you can overwrite them like this:

      -
        name: Docker meta
        id: meta
        uses: docker/metadata-action@v4
        with:
          images: name/app
          labels: |
            maintainer=CrazyMax
            org.opencontainers.image.title=MyCustomTitle
            org.opencontainers.image.description=Another description
            org.opencontainers.image.vendor=MyCompany

Link
I want to overwrite org.opencontainers.image.source and specified

       labels: |
          org.opencontainers.image.source=https://github.com/sergey-safarov/kamailio-ci

In the build log, I can see present two labels with the same key org.opencontainers.image.source
image

Expected behaviour

Actions output should contain only one key/value pairs. And I am able to overwrite default keys.

Actual behaviour

The output contains multiple key/value pairs. Build actions take the first pair and I not able overwrite default values.

@crazy-max
Copy link
Member

#125 (comment)

@crazy-max
Copy link
Member

Maybe we could remove dupes to avoid confusion. Let me know if that would be good for you.

@sergey-safarov
Copy link
Author

thanks @crazy-max, that will be optimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants