Fix bad order of iptables filter rules #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JrCs
force-pushed
the
fix-iptables-order
branch
3 times, most recently
from
ecc3a09
to
53d0c8a
Compare
|
@aboch can you PTAL |
Rules with ctstate RELATED,ESTABLISHED must be create before same rules without ctstate. Signed-off-by: Yves Blusseau <[email protected]>
JrCs
force-pushed
the
fix-iptables-order
branch
from
53d0c8a
to
d0ca14b
Compare
|
I have rebase my PR. |
|
LGTM |
|
Do you think it will be merge soon ? |
|
@JrCs Thanks and sorry about the really long delay. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules with ctstate RELATED,ESTABLISHED must be create before same rules without ctstate.
See moby/moby#18911