Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting HTTP scheme in store/consul/consul.go overwrites CONSUL_HTTP_SSL #151

Open
mcapuccini opened this issue Mar 14, 2017 · 0 comments · May be fixed by #152
Open

Setting HTTP scheme in store/consul/consul.go overwrites CONSUL_HTTP_SSL #151

mcapuccini opened this issue Mar 14, 2017 · 0 comments · May be fixed by #152

Comments

@mcapuccini
Copy link

mcapuccini commented Mar 14, 2017 •
edited
Loading

Hello!

This line https://github.com/docker/libkv/blob/master/store/consul/consul.go#L77 overwrites the setting that I am trying to pass via the environment variable CONSUL_HTTP_SSL to the hashicorp API. This makes impossible to connect to a consul server with HTTPS, and it is causing an issue in Traefik: traefik/traefik#1275.

Fixing the scheme to "https" shouldn't be necessary, as the hashicorp API does it by default (https://github.com/hashicorp/consul/blob/8a5164e14aa5464f807eed493c2fb70329ef2135/api/api.go#L216), so I guess you could remove that line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow to specify consul scheme (only HTTP is allowed at the moment) mcapuccini/libkv
1 participant
@mcapuccini