nat: remove deprecated PartParser() #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tiborvass @AkihiroSuda PTAL |
AkihiroSuda
approved these changes
Mar 15, 2021
thaJeztah
force-pushed
the
deadcode
branch
2 times, most recently
from
b62c8e8
to
1d26dda
Compare
thaJeztah
changed the title
|
@thaJeztah Do we need to wait for another LGTM ? |
This function was deprecated 5 Years ago in commit: 35dcbbc, That commit has been in releases v0.3.x and v0.4.x, so should now be fine to remove. Signed-off-by: Sebastiaan van Stijn <[email protected]>
dmcgowan
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PartParser() was deprecated 5 Years ago in commit: 35dcbbc (#19), which has been in releases v0.3.x and v0.4.x, so should now be fine to remove.