introduce String method on PortMapping #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
approved these changes
Jan 17, 2024
thaJeztah
reviewed
Jan 22, 2024
nat/nat.go
Outdated
| @@ -150,6 +150,10 @@ type PortMapping struct { | |||
| Binding PortBinding | |||
| } | |||
|
|
|||
| func (p *PortMapping) String() string { | |||
| return fmt.Sprintf("%s:%s:%s", p.Binding.HostIP, p.Binding.HostPort, p.Port) | |||
There was a problem hiding this comment.
We should use net.JoinHostPort() here, to account for IPv6 addresses; https://pkg.go.dev/net#JoinHostPort
e.g.;
Suggested change
| return fmt.Sprintf("%s:%s:%s", p.Binding.HostIP, p.Binding.HostPort, p.Port) | |
| return net.JoinHostPort(p.Binding.HostIP, p.Binding.HostPort+":"+p.Port.Port()) |
But I need to have a closer look, as there's many possible formats (ports mapped here can also have the protocol (e.g. 80/tcp), which may have to be taken into account here.
And of course we also have PortMap (which is a list of mapped ports) 😞
There was a problem hiding this comment.
Oh, I guess HostPort doesn't have the scheme, so maybe that part is not an issue
There was a problem hiding this comment.
Do we know if HostIP defaults to 0.0.0.0 (or :: IPv6)? 🤔
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
PortMapping_String
branch
from
008e7cc
to
a314a9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduce
PortMapping.String()for (some) symmetry withParsePortSpec