Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater expands variables in the PATH environment variable #859

Closed
brunoyb opened this issue Jun 29, 2017 · 7 comments
Closed

Updater expands variables in the PATH environment variable #859

brunoyb opened this issue Jun 29, 2017 · 7 comments

Comments

@brunoyb
Copy link

brunoyb commented Jun 29, 2017

I believe this could be happening when executing the installer also, but I didn't test with the installer, just with the self-update feature.

If before executing the update you had your PATH set to, for example:

%SystemRoot%\system32;%SystemRoot%;%SystemRoot%\System32\Wbem;%SYSTEMROOT%\System32\WindowsPowerShell\v1.0\;C:\Program Files\Docker\Docker\Resources\bin;

it will become:

C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Program Files\Docker\Docker\Resources\bin;

after the update is done.

I just updated to the version posted below and experienced this issue. I actually have to update my PATH environment variable every time Docker releases an update. I use %APPDATA% in one of my paths, which is user dependant, so when it is expanded it becomes C:\Users\<username>\AppData\Roaming setting it to the current user which is not what I intended.

If you need more information, just tell me and I will try to provide it. Thanks!

Version 17.06.0-ce-win17 (12626)
Channel: edge
4bb7a7d

@ebriney
Copy link
Member

ebriney commented Jul 4, 2017

It'll be fixed for next update. Thanks for the report.

@nlaplante
Copy link

Just updated to new version and now the docker command is not found:

PS C:\Users\Nicolas> docker
docker : The term 'docker' is not recognized as the name of a cmdlet, function, script file, or operable program.
Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
At line:1 char:1
+ docker
+ ~~~~~~
    + CategoryInfo          : ObjectNotFound: (docker:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

@ebriney
Copy link
Member

ebriney commented Jul 17, 2017

@nlaplante : Strange, is C:\Program Files\Docker\Docker\Resources\bin in your system path ?

@brunoyb
Copy link
Author

brunoyb commented Jul 18, 2017

Hi! I just updated to the new edge version (details below). The changelog stated this was fixed, but the problem still persists. My PATH was changed to have all variables expanded just like the example I gave in the original report.

Version 17.06.1-ce-rc1-win20 (12818)
Channel: edge
28a0bb2

@brunoyb
Copy link
Author

brunoyb commented Jul 25, 2017

I just found out that %APPDATA% actually doesn't really work for what I was trying to do (not on the system environment anyway). But the bug report is still valid as the standard Windows 10 environment Path usually comes defined with %SystemRoot% in it, and after installing/updating Docker it becomes C:\Windows.

Thanks for your attention!

@brunoyb
Copy link
Author

brunoyb commented Jul 31, 2017

I just updated to the new version and it seems to be fixed on this last update. Thanks!

Version 17.07.0-ce-rc1-win21 (12927)
Channel: edge
76a8c4b

@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

Send feedback to Docker Community Slack channels #docker-for-mac or #docker-for-windows.
/lifecycle locked

@docker docker locked and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants