Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[18.09 backport] builder-next: fix squash #176

Merged
merged 1 commit into from
Mar 28, 2019
Merged

[18.09 backport] builder-next: fix squash #176

merged 1 commit into from
Mar 28, 2019

Conversation

AkihiroSuda
Copy link

Tagger was not called for BuildKit-mode.

Signed-off-by: Akihiro Suda [email protected]
(cherry picked from commit 7fc0f82)
Signed-off-by: Akihiro Suda [email protected]

moby#38902

@AkihiroSuda
builder-next: fix squash
8d87a2a 
Tagger was not called for BuildKit-mode.

Signed-off-by: Akihiro Suda <[email protected]>
(cherry picked from commit 7fc0f82)
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda mentioned this pull request Mar 21, 2019
Merged
thaJeztah
thaJeztah approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah
Copy link
Member

hm.. this test is really flaky now

14:06:21 FAIL: docker_api_swarm_test.go:297: DockerSwarmSuite.TestAPISwarmLeaderElection
14:06:21 
14:06:21 [da0eb7627b9be] waiting for daemon to start
14:06:21 [da0eb7627b9be] daemon started
14:06:21 
14:06:21 [ddcb7049eef49] waiting for daemon to start
14:06:21 [ddcb7049eef49] daemon started
14:06:21 
14:06:21 [df963ac398d2d] waiting for daemon to start
14:06:21 [df963ac398d2d] daemon started
14:06:21 
14:06:21 [da0eb7627b9be] exiting daemon
14:06:21 assertion failed: error is not nil: Error response from daemon: rpc error: code = DeadlineExceeded desc = context deadline exceeded
14:06:21 [ddcb7049eef49] exiting daemon
14:06:21 [df963ac398d2d] exiting daemon
14:06:41

@thaJeztah thaJeztah added this to the 18.09.5 milestone Mar 28, 2019
andrewhsu
andrewhsu approved these changes Mar 28, 2019
View reviewed changes
Copy link

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 8c0845a into docker-archive:18.09 Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewhsu andrewhsu andrewhsu approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
18.09.5
Development

Successfully merging this pull request may close these issues.
3 participants
@AkihiroSuda @thaJeztah @andrewhsu