Updates for moby 28.0 networking #21612
Draft
+150
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
Signed-off-by: Rob Murray <[email protected]>
github-actions
bot
added
area/engine
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dvdksn
reviewed
Dec 12, 2024
Comment on lines
+70
to
+73
| For example, a frontend container may be connected to a bridge network | ||
| with external access, and a `--internal` network to communicate with | ||
| containers running backend services that do not need external network | ||
| access. |
There was a problem hiding this comment.
What is --internal, why is it written like a CLI flag?
There was a problem hiding this comment.
Good point - how about I make it a link to https://docs.docker.com/reference/cli/docker/network/create/#internal ?
Comment on lines
+84
to
+86
| The default gateway is selected by docker, and may change each time a | ||
| container's network connections change. | ||
| To make docker choose a specific default gateway when creating the container |
There was a problem hiding this comment.
Suggested change
| The default gateway is selected by docker, and may change each time a | |
| container's network connections change. | |
| To make docker choose a specific default gateway when creating the container | |
| The default gateway is selected by Docker, and may change whenever a | |
| container's network connections change. | |
| To make Docker choose a specific default gateway when creating the container |
Comment on lines
+88
to
+89
| in [docker run](/reference/cli/docker/container/run.md) and | ||
| [docker network connect](/reference/cli/docker/network/connect.md). |
There was a problem hiding this comment.
Suggested change
| in [docker run](/reference/cli/docker/container/run.md) and | |
| [docker network connect](/reference/cli/docker/network/connect.md). | |
| for the [`docker run`](/reference/cli/docker/container/run.md) and | |
| [`docker network connect`](/reference/cli/docker/network/connect.md) commands. |
| - Option `bip6` is optional, it specifies the address of the default bridge, which | ||
| will be used as the default gateway by containers. It also specifies the subnet | ||
| for the bridge network. | ||
| - Option `fixed-cidr-v6` is optional, it specifies the address range docker may |
There was a problem hiding this comment.
Suggested change
| - Option `fixed-cidr-v6` is optional, it specifies the address range docker may | |
| - Option `fixed-cidr-v6` is optional, it specifies the address range Docker may |
| @@ -229,6 +229,20 @@ When you create your network, you can specify the `--ipv6` flag to enable IPv6. | |||
| $ docker network create --ipv6 --subnet 2001:db8:1234::/64 my-net | |||
| ``` | |||
|
|
|||
| If you do not provide a `--subnet` option, a unique-local address (ULA) prefix | |||
There was a problem hiding this comment.
Suggested change
| If you do not provide a `--subnet` option, a unique-local address (ULA) prefix | |
| If you do not provide a `--subnet` option, a Unique Local Address (ULA) prefix |
Comment on lines
+139
to
+140
| Within a local layer-2 network, any remote host can set up a static route | ||
| to a container network via the docker host's address on the local network. |
There was a problem hiding this comment.
Suggested change
| Within a local layer-2 network, any remote host can set up a static route | |
| to a container network via the docker host's address on the local network. | |
| Within a local layer 2 network, remote hosts can set up static routes | |
| to a container network using the Docker daemon host's address on the local network. |
Comment on lines
+141
to
+143
| So, those local remote hosts can access containers directly. Remote hosts | ||
| outside the local network will only have direct access to containers if | ||
| routers are configured to enable it. |
There was a problem hiding this comment.
Suggested change
| So, those local remote hosts can access containers directly. Remote hosts | |
| outside the local network will only have direct access to containers if | |
| routers are configured to enable it. | |
| This allows local remote hosts to access containers directly. For remote | |
| hosts outside the local network, direct access to containers requires | |
| router configuration to enable the necessary routing. |
There was a problem hiding this comment.
Hmm, reading this again, "local remote hosts" are a bit weird!
How about I change it to ...
Within a local layer 2 network, remote hosts can set up static routes
to a container network using the Docker daemon host's address on the local
network. Those hosts can access containers directly. For remote
hosts outside the local network, direct access to containers requires
router configuration to enable the necessary routing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates for moby 28.0 networking.
Related issues or tickets
Series of commits ...
Reviews