Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pic-fix #15171

Merged
merged 2 commits into from
Jul 20, 2022
Merged

pic-fix #15171

merged 2 commits into from
Jul 20, 2022

Conversation

aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Jul 20, 2022 •
edited
Loading

Fixes mac install screenshot

@netlify
Copy link

netlify bot commented Jul 20, 2022 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit acea81e
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/62d7ad59683c0b00096a1ad4
😎 Deploy Preview https://deploy-preview-15171--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aevesdocker aevesdocker mentioned this pull request Jul 20, 2022
Closed
dockertopia
dockertopia approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@dockertopia dockertopia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
On a note, just wondering if we want/need to keep source file names shorter.

@aevesdocker
Copy link
Contributor Author

yes agreed they should be shorter, but I didn't want to spend too much time messing around with 'inherited' images.

@aevesdocker aevesdocker merged commit 08184fc into docker:master Jul 20, 2022
@aevesdocker aevesdocker deleted the pic-fix branch July 22, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dockertopia dockertopia dockertopia approved these changes

@usha-mandya usha-mandya Awaiting requested review from usha-mandya

@trungutt trungutt Awaiting requested review from trungutt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aevesdocker @dockertopia