Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keywords in upstream files are incorrectly formatted #2687

Closed
johndmulhausen opened this issue Apr 7, 2017 · 4 comments
Closed

keywords in upstream files are incorrectly formatted #2687

johndmulhausen opened this issue Apr 7, 2017 · 4 comments
Assignees
@mdlinville
Labels
area/engine Issue affects Docker engine/daemon area/ux Issue affects functionality of docs.docker.com lifecycle/locked
Milestone
engine/17.11

Comments

@johndmulhausen
Copy link

https://docs.docker.com/metadata.txt

Do a CMD+F search for "keywords":["

Any results you see here show that the keywords in these files are coming in as arrays. This shouldn't happen.

Bad front-matter:

---
keywords:
- foo, blar, snarf, barge
---

Good front-matter:

---
keywords: grog, bling, glorp, flan
---
@johndmulhausen johndmulhausen added area/ux Issue affects functionality of docs.docker.com area/engine Issue affects Docker engine/daemon labels Apr 7, 2017
johndmulhausen referenced this issue Apr 7, 2017
@johndmulhausen
Fix for upstream files w/bad keywords
96b09c1
@mdlinville mdlinville modified the milestone: engine/17.09 Aug 23, 2017
@johndmulhausen
Copy link
Author

Fixed in #96b09c1

@johndmulhausen johndmulhausen removed this from the engine/17.09 milestone Aug 29, 2017
@johndmulhausen
Copy link
Author

johndmulhausen commented Aug 29, 2017 •
edited
Loading

Eh, actually, my workaround is good for the site but it would be nice if the real upstream files had non-arrayed keywords; carry on.

@johndmulhausen johndmulhausen added this to the engine/17.09 milestone Aug 29, 2017
@mdlinville mdlinville modified the milestones: engine/17.09, engine/17.10 Sep 29, 2017
@mdlinville mdlinville modified the milestones: engine/17.10, engine/17.11 Oct 20, 2017
@mdlinville mdlinville mentioned this issue Oct 20, 2017
Merged
@mdlinville
Copy link

Closing here since the work will happen in the docker/distribution repo.

@docker-robott
Copy link
Collaborator

Closed issues are locked after 30 days of inactivity.
This helps our team focus on active issues.

If you have found a problem that seems similar to this, please open a new issue.

/lifecycle locked

@docker docker locked and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mdlinville mdlinville

Labels
area/engine Issue affects Docker engine/daemon area/ux Issue affects functionality of docs.docker.com lifecycle/locked
Projects
None yet
Milestone
engine/17.11
Development

No branches or pull requests
3 participants
@johndmulhausen @mdlinville @docker-robott