Skip to content

Commit

Permalink
feedback1
Browse files Browse the repository at this point in the history
Signed-off-by: Craig <[email protected]>
  • Loading branch information
craig-osterhout committed Dec 11, 2024
1 parent 387d34c commit a923fa5
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 14 deletions.
2 changes: 1 addition & 1 deletion content/manuals/docker-hub/repos/manage/builds/_index.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ image. The built image is then pushed to Docker Hub.
> You can still use `docker push` to push pre-built images to
repositories with automated builds configured.

If you have automated tests configured, these run after building but before
If you have automated tests configured, these run after building, but before
pushing to the registry. You can use these tests to create a continuous
integration workflow where a build that fails its tests doesn't push the built
image. Automated tests don't push images to the registry on their own. [Learn about automated image testing](automated-testing.md).
Expand Down
24 changes: 11 additions & 13 deletions content/manuals/docker-hub/repos/manage/builds/setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,6 @@ aliases:
> Automated builds require a
> Docker Pro, Team, or Business subscription.
This page contains information on:
- [Configuring automated builds](#configure-automated-builds)
- [Advanced automated build options](#advanced-automated-build-options)
- [Automated builds for teams](#autobuild-for-teams)

## Configure automated builds

You can configure repositories in Docker Hub so that they automatically
Expand Down Expand Up @@ -47,7 +42,7 @@ when the tests succeed.
> the source code provider. Once you select a user, source code
> repositories appear in the **Select repository** drop-down list.
5. Optional: Enable [autotests](automated-testing.md#enable-automated-tests-on-a-repository).
5. Optional. Enable [autotests](automated-testing.md#enable-automated-tests-on-a-repository).

6. Review the default **Build Rules**.

Expand All @@ -56,10 +51,11 @@ when the tests succeed.
within the Docker repository.

A default build rule is set up for you, which you can edit or delete. This
default rule sets builds from the `Branch` in your source code repository called
`master` or `main`, and creates a Docker image tagged with `latest`. For more information, see [set up build rules](#set-up-build-rules)
default rule sets builds from the `Branch` in your source code repository
called `master` or `main`, and creates a Docker image tagged with `latest`.
For more information, see [set up build rules](#set-up-build-rules).

7. Optional: Select the **plus** icon to add and [configure more build rules](#set-up-build-rules).
7. Optional. Select the **plus** icon to add and [configure more build rules](#set-up-build-rules).

8. For each branch or tag, enable or disable the **Autobuild** toggle.

Expand Down Expand Up @@ -279,9 +275,11 @@ variable to automated builds associated with the account. For more information,
2. Create a "build" team in your organization.
3. Ensure that the new "build" team has access to each repository and submodule you need to build.

Go to the repository's **Settings** page. On GitHub, add the new "build" team
to the list of **Collaborators and Teams**. On Bitbucket, add the "build" team
to the list of approved users on the **Access management** screen.
1. On GitHub or Bitbucket, go to the repository's **Settings** page.
2. Add the new "build" team to the list of approved users.

- GitHub: Add the team in **Collaborators and Teams**.
- Bitbucket: Add the team in **Access management**.

4. Add the service user to the "build" team on the source provider.

Expand All @@ -291,7 +289,7 @@ variable to automated builds associated with the account. For more information,
>
> You may need to sign out of your individual account on the source code provider to create the link to the service account.
6. Optional: Use the SSH keys you generated to set up any builds with private submodules, using the service account and [the previous instructions](troubleshoot.md#build-repositories-with-linked-private-submodules).
6. Optional. Use the SSH keys you generated to set up any builds with private submodules, using the service account and [the previous instructions](troubleshoot.md#build-repositories-with-linked-private-submodules).

## What's Next?

Expand Down

0 comments on commit a923fa5

Please sign in to comment.