Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay2: fix unmounting layer without merge dir #31069

Merged
merged 1 commit into from
Feb 17, 2017

Conversation

tonistiigi
Copy link
Member

@dmcgowan

Signed-off-by: Tonis Tiigi [email protected]

Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok but why wouldn't there be a merge dir?

@@ -30,7 +30,7 @@ import (
"github.com/docker/docker/pkg/mount"
"github.com/docker/docker/pkg/parsers"
"github.com/docker/docker/pkg/parsers/kernel"
"github.com/docker/go-units"
units "github.com/docker/go-units"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it's not needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like that though 👼

Copy link
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of those situations where I would have thought this was already done

LGTM

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@@ -30,7 +30,7 @@ import (
"github.com/docker/docker/pkg/mount"
"github.com/docker/docker/pkg/parsers"
"github.com/docker/docker/pkg/parsers/kernel"
"github.com/docker/go-units"
units "github.com/docker/go-units"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do like that though 👼

@vdemeester vdemeester merged commit 146bc07 into moby:master Feb 17, 2017
@GordonTheTurtle GordonTheTurtle added this to the 1.14.0 milestone Feb 17, 2017
@thaJeztah thaJeztah modified the milestones: 17.03.1, 17.04.0 Mar 9, 2017
@thaJeztah
Copy link
Member

cherry-picked into 17.03.1 through #31754

liusdu pushed a commit to liusdu/moby that referenced this pull request Oct 30, 2017
cherry-pick from: moby#31069

Signed-off-by: Tonis Tiigi <[email protected]>
Signed-off-by: Lei Jitang <[email protected]>
(cherry picked from commit e1af6c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants