Make release scripts architecture-agnostic and add ARM support #25591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborvass
added
process/cherry-pick
status/2-code-review
and removed
status/0-triage
labels
|
Ping @tianon @mlaventure |
|
Nice, LGTM |
|
LGTM |
|
why was this closed? didn't work? |
|
Yes, I have a fix but need to verify something else and didn't want this merged. |
tiborvass
force-pushed
the
fix-release-script
branch
from
369b5a3
to
69242b1
Compare
|
Ping @tianon again, sorry. For release-rpm this time. |
|
Nice, updated content still LGTM 👍 |
|
|
tiborvass
force-pushed
the
fix-release-script
branch
from
69242b1
to
2ff2e9a
Compare
This patch allows to only release the packages that were built and are present under the bundles/ directory instead of assuming packages exist for all distros enumerated in the contrib/builder/ directory. It also now adds support for armhf architecture for apt repositories. Signed-off-by: Tibor Vass <[email protected]>
|
@mlaventure fixed, thanks! |
|
LGTM! |
Merged
|
@tiborvass really nice patch. I already tried to resolve this without success so far, but your solution looks pretty good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows to only release the packages that were built and are
present under the bundles/ directory instead of assuming packages exist
for all distros enumerated in the contrib/builder/ directory.
It also now adds support for armhf architecture for apt repositories.
Signed-off-by: Tibor Vass [email protected]