Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force input stream ANSI emulation for ConEmu. #25578

Merged
merged 1 commit into from
Sep 8, 2016
Merged

Force input stream ANSI emulation for ConEmu. #25578

merged 1 commit into from
Sep 8, 2016

Conversation

rwilliams
Copy link
Contributor

@rwilliams rwilliams commented Aug 10, 2016 •
edited
Loading

Forces input stream ANSI emulation for ConEmu so arrow keys etc are read on docker run commands

Fixes #25475

![alt text](http://i.imgur.com/50QN6dO.jpg kitten)

Signed-off-by: Ron Williams [email protected]

@rwilliams rwilliams changed the title Force input emulation for ConEmu. Force input stream ANSI emulation for ConEmu. Aug 10, 2016
@thaJeztah
Copy link
Member

ping @jstarks @jhowardmsft

@njdarda njdarda mentioned this pull request Aug 19, 2016
Closed
@thaJeztah
Copy link
Member

ping @jstarks @jhowardmsft PTAL!

@Maximus5 Maximus5 mentioned this pull request Aug 21, 2016
Closed
@syepes
Copy link

syepes commented Aug 22, 2016

+1

2 similar comments
@viksabnis
Copy link

+1

@JohnLozano
Copy link

+1

@eug48
Copy link

eug48 commented Aug 30, 2016

Arrow keys are also not working in ConsoleZ. I'm using Docker for Windows 1.12.0-stable.

@lowenna
Copy link
Member

lowenna commented Sep 2, 2016

LGTM. Have not tested any conEmu functionality.

@cpuguy83
Copy link
Member

cpuguy83 commented Sep 8, 2016

LGTM

@cpuguy83 cpuguy83 merged commit 28d18b8 into moby:master Sep 8, 2016
@thaJeztah thaJeztah added this to the 1.12.2 milestone Sep 26, 2016
@thaJeztah
Copy link
Member

ping @vieux I added this one to the milestone for consideration. I discussed with @jstarks, and there should be no risk in this change, and it solves an issue that people run into when running interactive containers on a Windows client.

@vieux vieux mentioned this pull request Sep 26, 2016
Merged
@rn rn mentioned this pull request Sep 27, 2016
Closed
@jcwilson jcwilson mentioned this pull request Sep 28, 2016
Closed
@friism friism mentioned this pull request Nov 24, 2016
Closed
@thaJeztah thaJeztah mentioned this pull request May 7, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
platform/windows process/cherry-picked status/2-code-review
Projects
None yet
Milestone
1.12.2
Development

Successfully merging this pull request may close these issues.
10 participants
@rwilliams @thaJeztah @syepes @viksabnis @JohnLozano @eug48 @lowenna @cpuguy83 @vieux @GordonTheTurtle