ppc64le: add support for building docker debs for xenial #23438
Conversation
|
Unfortunately it is unclear if they will update |
| # xenial ships with libseccomp 2.2.3, but power wasn't supported until 2.3 | ||
| if [ "$suite" = 'xenial' ]; then | ||
| packages=( "${packages[@]/libseccomp-dev}" ) | ||
| fi |
There was a problem hiding this comment.
Put the runc and extra buildtags here as in https://github.com/docker/docker/blob/master/contrib/builder/deb/amd64/generate.sh#L93 so it is obvious how to enable seccomp, it could even be enabled for the default case so it works in future versions on the assumption they will have a recent enough version.
tophj-ibm
force-pushed
the
ppc64le-build-xenial-debs
branch
from
f127ac8
to
c0788fe
Compare
|
Yeah I agree, I'm not sure what's going on with the version, but I'll go ahead and submit a bug report on the ppc64le side for it. |
|
LGTM. |
|
okay, looks like power support was backported in an earlier release of libseccomp that I didn't see. I'm going to test some more and update this again. |
|
Ah that sounds hopeful... |
tophj-ibm
force-pushed
the
ppc64le-build-xenial-debs
branch
from
47c987c
to
858bd74
Compare
|
Updated. So all the tests passed with the xenial base version of seccomp enabled. Looking more into the package, power xenial seccomp just backported all the power and z related commits from 2.3.0 and 2.3.1 into 2.2.3-3 and just ignored all the x86 changes, hence it being an older version. |
|
LGTM |
|
Since the 1.12 madness is over, could this be rebased & looked at again? 🐱 |
|
I'll rebase and add in the man page dockerfile when I get back on Monday 😎 |
tophj-ibm
force-pushed
the
ppc64le-build-xenial-debs
branch
from
858bd74
to
3927723
Compare
|
Rebased and added in the dockerfile for the man pages. |
tophj-ibm
force-pushed
the
ppc64le-build-xenial-debs
branch
from
3927723
to
8606fd5
Compare
tophj-ibm
force-pushed
the
ppc64le-build-xenial-debs
branch
from
8606fd5
to
618fd8c
Compare
This PR adds the ability to make docker debs for xenial on power Signed-off-by: Christopher Jones <[email protected]> Signed-off-by: Christopher Jones <[email protected]>
tophj-ibm
force-pushed
the
ppc64le-build-xenial-debs
branch
from
618fd8c
to
64881dc
Compare
|
updated LGTM. |
|
LGTM |
|
Thanks guys!! 🎉 |
This PR adds the ability to make docker debs for xenial on ppc64le.
This is pretty standard except for a few specific power+xenial issues.
Seccomp isn't enabled by default because the latest package version is a bit too old tohave power support in it. Once that gets updated to 2.3+, it can be added back in.
Edit: The base xenial package (v2.2.3-3) contains backports of all the power and z related changes.
source. In order to build from source, we need a previous version of go, so we download that from
the xenial repo (go1.6.1), bootstrap build latest go, and then remove the older version.
Signed-off-by: Christopher Jones [email protected]