Add multi stage build best practices #5481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that we already have some information about multi-stage builds in this article on line 64. Do you care to move your changes closer to that, instead of putting them in the section |
mdlinville
suggested changes
Dec 16, 2017
| @@ -167,6 +167,53 @@ the command string itself will be used to find a match. | |||
| Once the cache is invalidated, all subsequent `Dockerfile` commands will | |||
| generate new images and the cache will not be used. | |||
|
|
|||
| ### Optimizing [multi-stage builds](multistage-build.md) | |||
Signed-off-by: Thibault Jamet <[email protected]>
mdlinville
approved these changes
Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
May I propose to add a best practice section regarding multi stage builds. Suggesting users best practices to benefit build cache, not rebuilding unnecessary things, for building applications while keeping very small final images.