Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use response.text to get string rather than bytes #3156

Merged
merged 2 commits into from
Aug 14, 2023
Merged

fix: use response.text to get string rather than bytes #3156

merged 2 commits into from
Aug 14, 2023

Conversation

mndeveci
Copy link
Contributor

@mndeveci mndeveci commented Jul 7, 2023

Fixes; #3151

response.content returns bytes which eventually fails at line 34 when searching for image not found error message.

This change fixes it by using response.text which returns string rather than bytes.

milas
milas approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@milas milas self-assigned this Aug 14, 2023
@milas milas merged commit 0618951 into docker:main Aug 14, 2023
@mndeveci mndeveci mentioned this pull request Oct 4, 2023
Closed
@milas milas mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milas milas milas approved these changes

@aiordache aiordache Awaiting requested review from aiordache

@ulyssessouza ulyssessouza Awaiting requested review from ulyssessouza

Assignees

@milas milas

Labels
kind/bug level/apiclient
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mndeveci @milas