Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move trimming whitespace to error-check helpers #306

Merged
merged 1 commit into from
Jan 10, 2024
Merged

move trimming whitespace to error-check helpers #306

merged 1 commit into from
Jan 10, 2024

Conversation

thaJeztah
Copy link
Member

some changes I had stashed locally 🤷 😂

@thaJeztah
Copy link
Member Author

Ah! Apparently that wasn't finished 😂

7.976 client/client.go:1: : # github.com/docker/docker-credential-helpers/client [github.com/docker/docker-credential-helpers/client.test]
7.976 client/client.go:61:81: undefined: t (typecheck)

@thaJeztah thaJeztah marked this pull request as draft January 9, 2024 15:45
@thaJeztah thaJeztah marked this pull request as ready for review January 10, 2024 09:58
@thaJeztah thaJeztah requested a review from crazy-max January 10, 2024 13:13
@thaJeztah thaJeztah merged commit f642c26 into docker:master Jan 10, 2024
10 checks passed
@thaJeztah thaJeztah deleted the err_checks branch January 10, 2024 13:40
@BrewTestBot BrewTestBot mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrea-reale andrea-reale andrea-reale approved these changes

@crazy-max crazy-max crazy-max approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thaJeztah @crazy-max @andrea-reale