osxkeychain: Delete(): return typed errors #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
osxkeychain_typed_error
branch
from
fd8cd57 to
71ceaf8
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #278 +/- ##
==========================================
- Coverage 55.55% 55.23% -0.32%
==========================================
Files 9 9
Lines 666 668 +2
==========================================
- Hits 370 369 -1
- Misses 253 256 +3
Partials 43 43
☔ View full report in Codecov by Sentry. |
|
@crazy-max ptal 🤗 |
1 task
crazy-max
reviewed
May 27, 2023
thaJeztah
force-pushed
the
osxkeychain_typed_error
branch
from
71ceaf8 to
0a405fb
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Makes the error-handling slightly cleaner. Signed-off-by: Sebastiaan van Stijn <[email protected]>
This allows a Delete for non-existing credentials to be handled. Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
osxkeychain_typed_error
branch
from
0a405fb to
b21b69c
Compare
|
@crazy-max updated; PTAL |
crazy-max
approved these changes
May 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a Delete for non-existing credentials to be handled.