use aws sdk to validate regions #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidswu
force-pushed
the
remove-region-validation
branch
from
1153d15
to
cab94e7
Compare
|
LGTM |
dmp42
approved these changes
Aug 20, 2018
|
LGTM |
dmcgowan
reviewed
Aug 20, 2018
registry/storage/driver/s3-aws/s3.go
Outdated
| } { | ||
| validRegions[region] = struct{}{} | ||
| resolver := endpoints.DefaultResolver() | ||
| partitions := resolver.(endpoints.EnumPartitions).Partitions() |
There was a problem hiding this comment.
I see there is also a endpoints.DefaultPartitions(), would this always return the same list?
There was a problem hiding this comment.
Yes let's use that instead
Signed-off-by: David Wu <[email protected]>
davidswu
force-pushed
the
remove-region-validation
branch
from
cab94e7
to
0b0d470
Compare
Codecov Report
@@ Coverage Diff @@
## master #2687 +/- ##
=======================================
Coverage 59.63% 59.63%
=======================================
Files 99 99
Lines 7893 7893
=======================================
Hits 4707 4707
Misses 2568 2568
Partials 618 618
Continue to review full report at Codecov.
|
|
Fixes #2619 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2619
Signed-off-by: David Wu [email protected]