Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove goamz #2671

Merged
merged 1 commit into from
Aug 10, 2018
Merged

Remove goamz #2671

merged 1 commit into from
Aug 10, 2018

Conversation

dmp42
Copy link
Contributor

@dmp42 dmp42 commented Aug 10, 2018

Standalone version of #2620 (no dep)

@dmp42 dmp42 mentioned this pull request Aug 10, 2018
Closed
RobbKistler
RobbKistler suggested changes Aug 10, 2018
View reviewed changes
Copy link

@RobbKistler RobbKistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove vendor/github.com/docker/goamz/*? I think that will fix the error in CI

@dmp42
Remove goamz
9caa7a8 
Signed-off-by: Olivier <[email protected]>
caervs
caervs reviewed Aug 10, 2018
View reviewed changes
Copy link
Contributor

@caervs caervs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@dmp42
Copy link
Contributor Author

dmp42 commented Aug 10, 2018

@RobbKistler PTAL

@dmcgowan
Copy link
Collaborator

LGTM

@dmcgowan dmcgowan merged commit 88530ef into distribution:master Aug 10, 2018
@dmp42
Copy link
Contributor Author

dmp42 commented Aug 20, 2018

Fixes #2617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caervs caervs caervs left review comments

@RobbKistler RobbKistler RobbKistler requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmp42 @dmcgowan @caervs @RobbKistler