Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration test certificates #2594

Merged
merged 2 commits into from
May 22, 2018

Conversation

dmcgowan
Copy link
Collaborator

Certs expired in May, and some were set to expire in August. Update certs and set expiration to 10 years.

Set expiration to 10 years

Signed-off-by: Derek McGowan <[email protected]>
@dmcgowan dmcgowan mentioned this pull request May 21, 2018
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Started looking into doing this but didn't find the time.

Should we have a script in the repository that automates this (if it's needed again in future?)

@thaJeztah
Copy link
Member

Oh, just saw "10 years" guess that's long enough haha

@thaJeztah
Copy link
Member

Odd; looks like vndr failed;

2018/05/21 23:05:02 Running time: 43.149602648s
Only in vendor/golang.org/x/crypto: otr
+ inconsistent dependencies! what you have in vendor.conf does not match with what you have in vendor
make: *** [dep-validate] Error 1

@dmcgowan
Copy link
Collaborator Author

Ahh yes, vndr updated, might as well make both changes

Signed-off-by: Derek McGowan <[email protected]>
@codecov
Copy link

codecov bot commented May 21, 2018

Codecov Report

Merging #2594 into master will decrease coverage by 9.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2594      +/-   ##
==========================================
- Coverage   60.87%   51.15%   -9.72%     
==========================================
  Files         129      129              
  Lines       11876    11818      -58     
==========================================
- Hits         7229     6046    -1183     
- Misses       3744     5011    +1267     
+ Partials      903      761     -142
Impacted Files Coverage Δ
registry/storage/driver/gcs/gcs.go 0.39% <0%> (-68.67%) ⬇️
registry/storage/driver/oss/oss.go 0.56% <0%> (-56.91%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.5% <0%> (-51.14%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.15% <0%> (-50.98%) ⬇️
registry/client/transport/transport.go 69.69% <0%> (-9.1%) ⬇️
registry/storage/driver/base/base.go 69.23% <0%> (-5.32%) ⬇️
...egistry/storage/cache/cachedblobdescriptorstore.go 42.22% <0%> (-3.62%) ⬇️
notifications/sinks.go 94.66% <0%> (-0.34%) ⬇️
notifications/endpoint.go 94.28% <0%> (-0.16%) ⬇️
configuration/configuration.go 68.33% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83389a1...dabcfdc. Read the comment docs.

@dmcgowan dmcgowan merged commit ed42a49 into distribution:master May 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants