-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update integration test certificates #2594
Update integration test certificates #2594
Conversation
Set expiration to 10 years Signed-off-by: Derek McGowan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Started looking into doing this but didn't find the time.
Should we have a script in the repository that automates this (if it's needed again in future?)
Oh, just saw "10 years" guess that's long enough haha |
Odd; looks like vndr failed;
|
Ahh yes, vndr updated, might as well make both changes |
Signed-off-by: Derek McGowan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2594 +/- ##
==========================================
- Coverage 60.87% 51.15% -9.72%
==========================================
Files 129 129
Lines 11876 11818 -58
==========================================
- Hits 7229 6046 -1183
- Misses 3744 5011 +1267
+ Partials 903 761 -142
Continue to review full report at Codecov.
|
Certs expired in May, and some were set to expire in August. Update certs and set expiration to 10 years.